Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.8 #895

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Add support for Python 3.8 #895

merged 1 commit into from
Mar 31, 2020

Conversation

japz
Copy link
Contributor

@japz japz commented Jan 24, 2020

Python 3.8 will thrown an exception if a dict changes while iterating over it,
copy it first.

Fix #890

Add support for Python 3.8
dd0bae6 
Python 3.8 will thrown an exception if a dict changes while iterating over it,
copy it first.

Fix pycontribs#890
@ssbarnea ssbarnea added the bug label Mar 31, 2020
@ssbarnea ssbarnea merged commit 0cf67df into pycontribs:master Mar 31, 2020
@wesinator wesinator mentioned this pull request Jun 25, 2020
Closed
@nsano-rururu nsano-rururu mentioned this pull request Oct 25, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@tomasbedrich tomasbedrich tomasbedrich approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method add_attachment() error with python 3.8 -- RuntimeError: dictionary keys changed during iteration
4 participants
@japz @ssbarnea @tomasbedrich @codectl